-
Notifications
You must be signed in to change notification settings - Fork 61.8k
fromJSON
should include an example of an array for runs-on
#20495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The working example is apparently commercialhaskell/stack@ba70082
|
👋 @jsoref Thanks for opening an issue. We appreciate all the details, too. I'll get this triaged for review. ⚡ |
Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀 |
This is a gentle bump for the docs team that this issue is waiting for technical review. |
This is a gentle bump for the docs team that this issue is waiting for technical review. |
This comment was marked as spam.
This comment was marked as spam.
This is a gentle bump for the docs team that this issue is waiting for technical review. |
This is a gentle bump for the docs team that this issue is waiting for technical review. |
This is a gentle bump for the docs team that this issue is waiting for technical review. |
Help me establish a link to github for an otp on the missing simcard |
This is a gentle bump for the docs team that this issue is waiting for technical review. |
This is a gentle bump for the docs team that this issue is waiting for technical review. |
This is a gentle bump for the docs team that this issue is waiting for technical review. |
This is a gentle bump for the docs team that this issue is waiting for technical review. |
I've had a look at this but am not familiar enough with this area to know whether, where, and how this should be documented, so I've asked for some SME assistance. Hopefully we can move this issue along soon. |
The answer I've had on this is that the strings provided as the value of
Expressions must be quoted:
Perhaps to resolve this issue we could add some clarification of this to the syntax details for |
Maintainer's note
We researched the question raised by this issue and provided clarification in this comment: #20495 (comment)
To open a PR against this issue, please add clarification of this syntax in the "
jobs.<job_id>.runs-on
" section of the "Workflow syntax for GitHub Actions" article.Code of Conduct
What article on docs.github.com is affected?
https://docs.github.com/en/actions/learn-github-actions/expressions#fromjson
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on
What part(s) of the article would you like to see updated?
Add an
example-returning-a-runs-on-array
similar to https://docs.github.com/en/actions/learn-github-actions/expressions#example-returning-a-json-objectAdditional information
Normally in JSON, the basic types are:
In GitHub Workflows, strings are strange in that, maybe? they don't need to be wrapped in quotes, some of the time?
Except, in the example https://docs.github.com/en/actions/learn-github-actions/expressions#example-returning-a-json-object, keys and values are wrapped in quotes:
When I tried to add some magic for a dynamic
runs-on
that would sometimes be a string and sometimes be an array, I naively assumed that I'd need to wrap my array elements in quotes, but that didn't do the right thing.See this PR:
commercialhaskell/stack#5856 (comment)
We can't seem to get this to work...
merge change https://github.com/commercialhaskell/stack/runs/8254107160?check_suite_focus=true
merge change https://github.com/commercialhaskell/stack/runs/8254719771?check_suite_focus=true
merge change https://github.com/commercialhaskell/stack/runs/8255017367?check_suite_focus=true
merge change https://github.com/commercialhaskell/stack/runs/8255163889?check_suite_focus=true
The last output appears to match the output for the working world
workflow https://github.com/commercialhaskell/stack/runs/8255316015?check_suite_focus=true
The text was updated successfully, but these errors were encountered: