Skip to content

Conversation

iansan5653
Copy link
Member

We can avoid future potential conflicts between regular keys and symbol plane keys by not checking the symbol plane map unless Alt is pressed. This is an easy safeguard that should make bugs like the one that #113 fixed less likely to happen in the future.

@iansan5653 iansan5653 requested a review from a team as a code owner December 5, 2023 16:14
@iansan5653 iansan5653 requested a review from jfuchs December 5, 2023 16:14
@JoyceZhu JoyceZhu requested review from a team and accessibility-bot December 5, 2023 16:41
@iansan5653 iansan5653 merged commit caec920 into main Dec 5, 2023
@iansan5653 iansan5653 deleted the no-symbol-plane-without-alt branch December 5, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants