Ask for local app fallback when Timed out while waiting for handshake
#20
Conversation
src/remoteConnector.ts
Outdated
| } else if (e instanceof SSHError && e.message === 'Timed out while waiting for handshake') { | ||
| this.logger.error('SSH test connection error:', e); | ||
| const ok = 'Ok'; | ||
| const action = await vscode.window.showWarningMessage(`Timed out while waiting for SSH handshake, it's possible SSH connections on port 22 are blocked or your network is too slow, connecting via the deprecated SSH tunnel over WebSocket.`, ok); |
There was a problem hiding this comment.
cc @akosyakov if you want to tweak the message
There was a problem hiding this comment.
it looks good to me
cc @loujaybee
There was a problem hiding this comment.
| @@ -565,6 +565,7 @@ export default class RemoteConnector extends Disposable { | |||
| }).connect({ | |||
| host: sshDestInfo.hostName, | |||
| username: sshDestInfo.user, | |||
| readyTimeout: 40000, | |||
There was a problem hiding this comment.
What is it seconds? 40? I don't mind making it higher like 1-2 minutes. WDYT? cc @mustard-mh @iQQBot
There was a problem hiding this comment.
yes seconds, we can increase it more but that would mean their network it's just too slow and the experience would be subpar (I guess that's up to the user to decide so ¯\_(ツ)_/¯), if it takes 1 minute to do the check it will take another minute to connect again using remote-ssh extension 😬
There was a problem hiding this comment.
Is it possible to show a process bar when connecting and show "fallback to/try with local-app" action after 20 seconds? 40s or 1-2minutes are too long to wait
There was a problem hiding this comment.
Is it possible to show a process bar when connecting
yeah possible but this connection does nothing it's just a quick test to check if port is not blocked so not sure if we should expose it to the user
There was a problem hiding this comment.
Is it possible to show a process bar when connecting and show "fallback to/try with local-app" action after 20 seconds? 40s or 1-2minutes are too long to wait
I mean generally it should be very quick, so maybe it is not bad to show progress bar if you really have problems, then we need to add some messaging Verifying SSH connection...
There was a problem hiding this comment.
Yes, this test should be very quick, if handshake take 40s, It's hard to imagine what the latency would be once you've successfully connected
@jeanp413 Any guidance how to do it? Maybe we should document it in https://www.notion.so/gitpod/VS-Code-Knowledge-sharing-FAQ-s-23145c3d43dd4b6db25b9f02486de3e0 |
Co-authored-by: Filip Troníček <[email protected]>
jeanp413
force-pushed
the
jp/handle-handshake-timeout
branch
from
8f6ef93 to
9251450
Compare
Added a link in the description for linux, don't know if it works for mac |
There was a problem hiding this comment.
I think code-wise it looks good beside: https://github.com/gitpod-io/gitpod-vscode-desktop/pull/20/files#r960355213
we should always continue execution does not matter how a user closed the warning with cancel or OK
I have not tried it. @mustard-mh @filiptronicek could you help with testing 🙏
|
Tested by change source code
All good, as close notification will also fallback to local-app [1] |
Description
Ask for local app fallback when
Timed out while waiting for handshakeAdd
gitpodHostcustom attribute to configcatRelated Issue(s)
Fixes gitpod-io/gitpod#12475
How to test
To block port 22 you can follow https://www.digitalocean.com/community/tutorials/how-to-set-up-a-firewall-with-ufw-on-ubuntu-18-04 if you are on linux