Skip to content

Show error logs on the loading screen if dotfiles installation script exits with a non-zero code #13004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
axonasif opened this issue Sep 15, 2022 · 3 comments
Labels
feature: dotfiles meta: stale This issue/PR is stale and will be closed soon team: webapp Issue belongs to the WebApp team type: bug Something isn't working

Comments

@axonasif
Copy link
Member

axonasif commented Sep 15, 2022

Bug description

It can be hard to notice that your dotfiles script is failing suddenly. In order to inspect $HOME/.dotfiles.log, it's necessary to at least have the IDE start but if you have a relatively complex dotfiles installation script and it fails, it can sometimes cause the IDE to not start.

Steps to reproduce

  • In your dotfiles script, do something like sudo rm -rf /ide

Workspace affected

No response

Expected behavior

The loading splash screen to show an error if the dotfiles installation script fails, the user may acknowledge this by pressing an button to continue loading the workspace.

It might be also nice to have an extra button on the loading screen to view dotfiles.log in case the dotfiles installation script didn't return an error code for users with dotfiles.

Example repository

No response

Anything else?

I experienced this myself several times.
Also a report internally on slack.

Related: #12100

@stale
Copy link

stale bot commented Dec 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Dec 16, 2022
@fcsonline
Copy link

Our team is really interested on having this feature. If not it is really hard to debug what is going on if something fails.

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Dec 16, 2022
@stale
Copy link

stale bot commented Mar 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Mar 18, 2023
@stale stale bot closed this as completed Apr 2, 2023
@github-project-automation github-project-automation bot moved this to In Validation in 🍎 WebApp Team Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: dotfiles meta: stale This issue/PR is stale and will be closed soon team: webapp Issue belongs to the WebApp team type: bug Something isn't working
Projects
Status: In Validation
Development

No branches or pull requests

2 participants