Skip to content

Dotfiles debugging support for inner loop (gp rebuild) #16349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
axonasif opened this issue Feb 10, 2023 · 5 comments
Closed

Dotfiles debugging support for inner loop (gp rebuild) #16349

axonasif opened this issue Feb 10, 2023 · 5 comments
Labels
feature: dotfiles feature: gp validate meta: stale This issue/PR is stale and will be closed soon team: IDE

Comments

@axonasif
Copy link
Member

axonasif commented Feb 10, 2023

Is your feature request related to a problem? Please describe

Iterating and debugging dotfiles for Gitpod would be equally useful as with .gitpod.yml.

Describe the behaviour you'd like

💭 As an user I imagine it to be:

  • If ~/.dotfiles dir exists on the parent workspace, share a clone of it in the debug workspace.
  • If the user opens their dotfiles repo as a workspace, share that as ~/.dotfiles in the debug workspace instead of sharing from the parent workspace $HOME/.dotfiles.
  • Have a --dotfiles-dir flag to specify a custom dir of dotfiles. (nice to have)
  • From where dotfiles dir is being shared could be informed to the user through terminal logs.
  • If the user updates the dotfiles link on https://gitpod.io/preferences, inform and maybe switch to it?

Describe alternatives you've considered

Additional context

Some more context here 🙏

@axonasif
Copy link
Member Author

axonasif commented Feb 10, 2023

@akosyakov
Copy link
Member

akosyakov commented Feb 10, 2023

Debug workspace should share what is actually shared between workplace restarts, ie /workspace. Nothing else should be by design. Instead as any other workpace it should go via initialization of dotifles on each start. If it does not happen then it is a bug. Adding —dotfiles option makes sense to iterate on dotfiles repo itself.

@axonasif
Copy link
Member Author

axonasif commented Feb 10, 2023

Debug workspace should share what is actually shared between workplace restarts, ie /workspace.

dotfiles may not be directly saved between restarts but it's applied/installed between restarts and can influence the startup of a workspace. Having the capability to only test dotfiles would be useful too as you mentioned. However, sometimes the /workspace repo context is needed for debugging some specific automation.

@akosyakov
Copy link
Member

akosyakov commented Feb 10, 2023

It is the point. It should work as for normal workpace, ie applied/installed each time exactly the same way. Not in any new way.

To be clear I’m not opposed of a flag to pick up from local dif, so you can checkout yourself your dotfile repo in any workspace and point to it. But otherwise it should behave exactly like for the outer. The only difference to normal run should be shared /workspace mount by default. If something else is different we should fix it.

@stale
Copy link

stale bot commented Jun 10, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jun 10, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: dotfiles feature: gp validate meta: stale This issue/PR is stale and will be closed soon team: IDE
Projects
None yet
Development

No branches or pull requests

3 participants