Skip to content

Fix dark theme colors and overflowing rounded corners for the project import pages #4717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gtsiolis opened this issue Jul 6, 2021 · 2 comments · Fixed by #5481
Closed

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Jul 6, 2021

Problem to solve

Some components on the project import pages added back in #4443 are not using appropriate colors for the dark theme and border radius is overflowing for some elements.

Although there are no design specs for these specific elements in dark mode, it could be relatively easy to reuse the same border colors as the rest of the product when using dark theme and remove the overflowing rounded corners.

Select Repository Select Team Projects List
Screenshot 2021-07-05 at 11 03 08 PM Screenshot 2021-07-05 at 11 03 59 PM Screenshot 2021-07-05 at 11 02 31 PM
@gtsiolis gtsiolis changed the title Fix dark theme colors and layouts for the project import pages Fix dark theme colors and overflowing rounded corners for the project import pages Jul 6, 2021
@jankeromnes
Copy link
Contributor

This can be achieved by always adding a overflow-hidden class next to the rounded-xl class on the containers.

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Sep 1, 2021

Thanks for taking a look at this @jankeromnes! Most design issues here have been resolved with the changes in #5120 and #5098 as some nested elements with rounded corners have been removed and colors have been updated.

Added #5481 to resolve the rest of the minor issues here.

Couldn't make overflow-hidden work but maybe I've missed something. Tried using rounded-t-xl when needed. Although these are still suffering from the same issue as is #5086. However, all these issues would be resolved with #4951. 💡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants