Skip to content

Interchage private and public port visibility icon on the editor #7662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gtsiolis opened this issue Jan 18, 2022 · 6 comments
Closed

Interchage private and public port visibility icon on the editor #7662

gtsiolis opened this issue Jan 18, 2022 · 6 comments
Labels

Comments

@gtsiolis
Copy link
Contributor

Problem to solve

Currently, the icon of the port visibility button on the on the Remote Explorer panel for VS Code, is confusing as a user has to click the unlocked button to make a port private.

See relevant discussions from the 🍊 Gitpod[1] (internal) and 🦊 GitLab[2] (internal).

Cc @akosyakov @loujaybee

Screenshot 2021-08-17 at 10 46 02 AM

Proposal

Interchage private and public port visibility icon, so that public ports are using the unlocked icon. 🔒

@gtsiolis gtsiolis changed the title Interchage private and public port visibility icon Interchage private and public port visibility icon on the editor Jan 18, 2022
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Feb 9, 2022

Looping in @loujaybee in case this could be a easy fix that's also confusing to others, too.

@loujaybee
Copy link
Member

Thanks @gtsiolis ! For sure does look like a small fix, let's see if we can get it updated soon! 🙏

@shaal
Copy link
Contributor

shaal commented Apr 16, 2022

Yes please 😍

@stale
Copy link

stale bot commented Aug 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Aug 12, 2022
@gtsiolis
Copy link
Contributor Author

Closing as this has been resolved. Cc @shaal @loujaybee

@shaal
Copy link
Contributor

shaal commented Aug 12, 2022

🎉 THANK YOU @gtsiolis !!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants