Skip to content

Last terminal on gitpod.yml is not focused #9473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sinansonmez opened this issue Apr 21, 2022 · 9 comments
Closed

Last terminal on gitpod.yml is not focused #9473

sinansonmez opened this issue Apr 21, 2022 · 9 comments
Labels
team: IDE type: bug Something isn't working

Comments

@sinansonmez
Copy link

Bug description

There are three terminals listed on .gitpod.yml. One of the terminals include openMode: split-right
Expected behaviour is that last one should be in focus. However because of openMode: split-right the focus is on splitted terminals. When i remove openMode: split-right, it works as expected.

Steps to reproduce

Open this repo in Gitpod

Workspace affected

https://github.com/mattermost/mattermost-gitpod-config

Expected behavior

No response

Example repository

No response

Anything else?

No response

@loujaybee
Copy link
Member

loujaybee commented May 11, 2022

The ability to explicitly focus on a terminal could make sense as a gitpod.yml property. How often does this issue affect you? Is there a reason why opening up the editor and needing the focus is more important? Is this whilst stopping and starting a workspace to update .gitpod.yml or similar? Or just for general work?

@loujaybee loujaybee added feature: gitpod yml All things related to the gitpod.yml type: feature request New feature or request labels May 11, 2022
@sinansonmez
Copy link
Author

When starting workspace, I am opening multiple terminal (run server, run react based front end and others).

In one of the terminal, I am asking user to enter some inputs such as github username. That is why I want to focus on this terminal so user see the request and enter the requested information.

@axonasif
Copy link
Member

axonasif commented Jun 3, 2022

Hey @sinansonmez, currently as a workaround you can just put the task below all and it should stay focused.
We're also doing it here: https://github.com/gitpod-io/template-flutter/blob/e4e1645db4a3035a5935344e65411eee913e35d3/.gitpod.yml#L57
You can also try opening the above template on Gitpod to see.

@sinansonmez
Copy link
Author

sinansonmez commented Jun 5, 2022

Hey @axonasif, this is actually the issue. Even though I put the terminal at end, it doesn't stay focused.

The reason is that one of the terminals has openMode: split-right. It is focused on the terminal with openMode: split-right not on the last one.

When I remove openMode: split-right, it works as expected: i.e. last one stays focused.

@stale
Copy link

stale bot commented Sep 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Sep 8, 2022
@stale stale bot closed this as completed Sep 25, 2022
@vickybiswas
Copy link

I am having the same problem.
The last tab is not getting the focus and instead, the last split-right tab is.
I need my user to be focusing on this and giving inputs.
Is there any known solution?

@akosyakov
Copy link
Member

@vickybiswas Could you create a new issue? I think behavoiur is correct, we focus last created terminal. But we may allow to mark a task which should be focused in .gitpod.yml.

cc @jeanp413 @felladrin How hard it would support in VS Code and JetBrains?

jeanp413 added a commit to gitpod-io/openvscode-server that referenced this issue Dec 14, 2022
@jeanp413
Copy link
Member

This is a peculiar vscode quirk on how it creates terminals, internally terminal creation is async and even though we focus each one in the order they appear in gitpod.yml it can happen that terminal.show() for a split terminal runs after other terminals created after it as it needs to await for it's parent terminal to completely resolve internally.

Pushed a fix gitpod-io/openvscode-server@7a4435f

@jeanp413 jeanp413 added type: bug Something isn't working and removed meta: stale This issue/PR is stale and will be closed soon feature: gitpod yml All things related to the gitpod.yml type: feature request New feature or request labels Dec 14, 2022
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Dec 14, 2022
@felladrin
Copy link
Contributor

felladrin commented Dec 15, 2022

@felladrin How hard it would support in VS Code and JetBrains?

IntelliJ Remote Dev API currently has no method for controlling the focus on terminals running in JetBrains Client. We also can't control the order the terminals are displayed. Terminal splitting is also not possible at the moment.

mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this issue Dec 16, 2022
filiptronicek pushed a commit to gitpod-io/openvscode-server that referenced this issue Dec 20, 2022
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Dec 20, 2022
filiptronicek pushed a commit to gitpod-io/openvscode-server that referenced this issue Dec 22, 2022
filiptronicek pushed a commit to gitpod-io/openvscode-server that referenced this issue Dec 23, 2022
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Dec 23, 2022
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Dec 26, 2022
mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 3, 2023
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 3, 2023
mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 5, 2023
mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 6, 2023
filiptronicek pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 8, 2023
mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 9, 2023
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 9, 2023
jeanp413 added a commit to gitpod-io/openvscode-server that referenced this issue Jan 11, 2023
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 11, 2023
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 12, 2023
jeanp413 added a commit to gitpod-io/openvscode-server that referenced this issue Jan 14, 2023
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 16, 2023
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 17, 2023
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 18, 2023
filiptronicek pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 23, 2023
jeanp413 added a commit to gitpod-io/openvscode-server that referenced this issue Jan 25, 2023
jeanp413 added a commit to gitpod-io/openvscode-server that referenced this issue Jan 26, 2023
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 26, 2023
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: IDE type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants