Skip to content

Update spacing between theme options #10135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2022
Merged

Update spacing between theme options #10135

merged 1 commit into from
May 19, 2022

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented May 19, 2022 •
edited
Loading

Description

Following up from #10111, minor spacing update between theme options. ☺️

How to test

Go to theme preferences and notice the spacing between the theme options when compared with the editor options.

Screenshots

BEFORE AFTER
theme-before theme-after

Release Notes

Update spacing between theme options

@gtsiolis gtsiolis marked this pull request as ready for review May 19, 2022 18:47
@gtsiolis gtsiolis requested a review from a team May 19, 2022 18:47
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 19, 2022
jankeromnes
jankeromnes approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesss 🤩🎯✨

@roboquat roboquat merged commit 484b9fc into main May 19, 2022
@roboquat roboquat deleted the gt/update-spacing-between-theme-options branch May 19, 2022 19:15
@gtsiolis
Copy link
Contributor Author

gtsiolis commented May 19, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Thanks, @jankeromnes! 🍯

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jankeromnes jankeromnes jankeromnes approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gtsiolis @jankeromnes @roboquat