-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Refactor cmd tasks
and ports
supervisor related func
#10403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
how about move |
I'm ok with that 👍 Then you could also move the contents from |
tasks
and ports
supervisor related functasks
and ports
supervisor related func
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code reviewed and commands (ports/tasks) tested! ✅
Description
Currently command
gp tasks
andgp ports
not handle errors properly, i.e.supervisor.Dial
func)supervisor
can be confusingThis PR
package cmd
api
tosupervisor
supervisor-helper
folderFor
gp tasks
GetTasksList
func for the same reasonRelated Issue(s)
Fixes #
How to test
go run main.go tasks xxx
behave the same withgp tasks xxx
gp ports list
behave the same with prev PR [gitpod-cli] Add command 'gp ports list' #10388Release Notes
Documentation