-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[gp-cli] Add alias for forward and await in ports #10463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks a lot for the contribution @CuriousCorrelation 🙏 We want to slowly migrate usage over to the new alias so in order to do that, I would like to suggest if you could hide the old commands from the usage. You can do that by adding var awaitPortCmd = &cobra.Command{
Hidden: true,
Use: "await-port <port>",
... and var portFwdCmd = &cobra.Command{
Hidden: true,
Use: "forward-port <local-port> [target-port]",
... By setting 🙏 🙏 🙏 |
Before we can merge your first contribution, we kindly ask you to sign a Contributor License Agreement (CLA)[1]. cc @meysholdt will reach out about the CLA :) |
@andreafalzetti let me know if my latest commit looks good or something needs change
Yes, of course |
hi @CuriousCorrelation! To get the CLA signed, can you please send me an email to |
@meysholdt Done! |
@CuriousCorrelation Thanks! Can I ask you to rebase and squash your commits so that when we merge it's a single commit? We have an automated system that merges the PR once I approve, so we won't be able to do it from the GitHub UI. 🙏 |
/werft run 👍 started the job as gitpod-build-main-fork.33 |
The build is failing, could you try rebasing from main?
|
@andreafalzetti Hey I tried squash and rebase but unfortunately it didn't work. I kept getting |
@andreafalzetti I think that PR should be good to go but please feel free to let me know if I should change something |
Description
This PR aliases
forward-port
andawait-port
command toports
namespace asports forward
,ports await
Related Issue(s)
Closes #10449
How to test
Both commands should be similar except for their
Usage
messageforward-port
await-port
Release Notes
Documentation
Does this PR require updates to the documentation at www.gitpod.io/docs?
Please create a docs issue: https://github.com/gitpod-io/website/issues/new?labels=documentation&template=DOCS-NEW-FEATURE.yml&title=%5BDocs+-+New+Feature%5D%3A+%3Cyour+feature+name+here%3E
Paste the link to the docs issue below this comment
https://github.com/gitpod-io/website/issues/2173#issue-1260679472