-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[dashboard] allow to open desktop links on app domain #12102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
started the job as gitpod-build-ak-open-desktop-link.1 because the annotations in the pull request description changed |
@akosyakov I followed the steps here, but when I opened another workspace, I was still prompted by the pop-up. . |
@laushinka you should use prev env of another PR. This PR only bring necessary changes which should be deployed before by webapp team. |
@akosyakov I guess this PR is already tested and reviewed. What behavior should I test on this one? |
mostly code review, you can check for regressions but you did it already, ie it still works like on main if all good I would generally approve and /hold on new line to let author address typos, nits and merge later 🙏🏻 |
Approving with a hold to address comments later. /hold |
0a08418
to
edccff5
Compare
/unhold |
Description
It is supporting PR for #12082. It should be deployed by the webapp team before.
Related Issue(s)
Fixes #
How to test
Test #12082
Release Notes
Documentation
Werft options: