[public-api] Implement delete token

[jeanp413]

Description

Implements delete token

Related Issue(s)

Fixes #14613

Release Notes

NONE

Documentation

Werft options:

• /werft with-local-preview
  If enabled this will build install/preview
• /werft with-preview
• /werft with-large-vm
• /werft with-integration-tests=all
  Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

[jeanp413]

/werft run

👍 started the job as gitpod-build-jp-public-api-delete.1
(with .werft/ from main)

[easyCZ]

[nit] To follow Go recommended style.

Suggested change

	return 0, fmt.Errorf("Failed to delete token: %v", db.Error)
	return 0, fmt.Errorf("failed to delete token (ID: %s): %v", tokenID.String(), db.Error)

We do use first letter uppercase in the API Handlers to provide a cleaner user-facing error message, but here in the db package we can stick to standard Go practice.

Here, the suggestion also includes the Token ID in the error. This makes tracking down the entry a bit simpler and I'd generally recommend including non sensitive IDs in the errors like this

There are a couple more occurrences of the uppercase.

[mustard-mh]

We have lots of params checkings like code below, they are uppercase too, should we change them all? If so, it could be a follow-up PR. cc @easyCZ

if req.UserID == uuid.Nil {
	return PersonalAccessToken{}, fmt.Errorf("Invalid or empty userID")
}

[easyCZ]

So the only place where we "should" use Uppercase is the apiv1 handler code. As that's what ultimately returns a response to the user. Everywhere else errors should start with lowercase as per standard go style. Sorry, this is a bit confusing. Maybe I can write a middleware which uppercases the first letter of the error to get rid of this inconcistency.

[easyCZ]

Nice work!