Skip to content

[pat] Apply on-update property to _lastModified column, remove from expirationTime #15093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Dec 1, 2022

Description

In #15015 (comment), we've identified that the table has the on-update extra property on the wrong column. This migraiton moves it to the _lastModified column, and removes it from teh expirationTime column

Related Issue(s)

Fixes #

How to test

CI runs the migrations on a local DB, tests in the public api use those migrations to run unit tests

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@easyCZ easyCZ requested a review from a team December 1, 2022 10:42
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Dec 1, 2022
@easyCZ easyCZ mentioned this pull request Dec 1, 2022
4 tasks
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-mp-pat-migration-fix-on-update.1 because the annotations in the pull request description changed
(with .werft/ from main)

Copy link
Member

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 82e56ca into main Dec 1, 2022
@roboquat roboquat deleted the mp/pat-migration-fix-on-update branch December 1, 2022 10:53
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants