-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[go] clean up gen of go types #15109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In order to allow unmarshalling of config passed from server to ide-service and marhsalling back as JSON.
started the job as gitpod-build-ak-go-prot-gen.1 because the annotations in the pull request description changed |
To what extend do we control the |
@easyCZ We use |
maybe it's a good idea, we can fork this repo and do some change. cc @akosyakov |
@iQQBot ok, it is up to you |
/hold to approve given you're the appropriate owners (and don't want to block you) but in case you want to make some changes |
/werft run recreate-vm=true 👍 started the job as gitpod-build-ak-go-prot-gen.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test with gitpod repo, it works
/unhold we discuss we use this way first, and do a fork if we still need some advanced change |
Description
In context of #15062 we need to pass config from server to ide-service.
But because of current code generator we cannot unmarshall it and marshall back additional tasks.
This PR simplifies code generated output that it has only types and rely on default go logic for marshalling.
Related Issue(s)
Related to #9189
How to test
Start a workspace with IntelliJ and VS Code with .gitpod.yml with extensions/plugins/ports and see whether UI respect it.
Release Notes
Documentation
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh