Skip to content

[JetBrains-Gateway] fix-IDEA2022.3-gradle-runIde #15646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2023
Merged

[JetBrains-Gateway] fix-IDEA2022.3-gradle-runIde #15646

merged 1 commit into from
Jan 12, 2023

Conversation

zhipengzuo
Copy link
Contributor

@zhipengzuo zhipengzuo commented Jan 10, 2023 •
edited by loujaybee
Loading

Signed-off-by: 勇里 [email protected]

Description

when I runIde with 2022.3.1 IDEA ,it shows
image
the log shows :
JNA library is not available

see the issue at https://youtrack.jetbrains.com/issue/IDEA-265943/Due-to-JNA-outdate-runIde-failed-on-Apple-silicon-with-IC-2020.3.3#focus=Comments-27-6739382.0-0
need to update org.jetbrains.intellij to 1.11.0
after change the version ,the runIde task is ok.

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@zhipengzuo zhipengzuo requested a review from a team January 10, 2023 06:44
@werft-gitpod-dev-com

This comment was marked as resolved.

Sign in to view
@zhipengzuo zhipengzuo changed the title fix-IDEA2022.3-gradle-runIde [JetBrains-Gateway] fix-IDEA2022.3-gradle-runIde Jan 10, 2023
@felladrin
Copy link
Contributor

Thanks for your contribution, @zhipengzuo!
Before merging it, we need to have your signed Contributor License Agreement (CLA) on file.
You can sign it via this DocuSign form.
If you have any questions about this, please let me know.

(cc @meysholdt)

@zhipengzuo
Copy link
Contributor Author

Thanks for your contribution, @zhipengzuo! Before merging it, we need to have your signed Contributor License Agreement (CLA) on file. You can sign it via this DocuSign form. If you have any questions about this, please let me know.

(cc @meysholdt)

I have signed it .

@felladrin

This comment was marked as resolved.

Sign in to view
@felladrin
Copy link
Contributor

Thank you!

I see the build is failing, but not due to the changes from this PR.
It's failing because we currently have the same platform version defined for Stable [1] and Latest [1] versions (223.8214.51-CUSTOM-SNAPSHOT). As the build runs concurrently for both versions on CI, we get this error [1]:

FAILURE: Build failed with an exception.

* What went wrong:
Could not determine the dependencies of task ':prepareSandbox'.
> Failed to query the value of task ':prepareSandbox' property 'librariesToIgnore'.
   > java.nio.file.FileAlreadyExistsException: /workspace/.gradle/caches/modules-2/files-2.1/com.jetbrains.gateway/JetBrainsGateway/223.8214.51-CUSTOM-SNAPSHOT/e8718bcc06faf0aa0d2d3ab9c026999ba39fae5f/JetBrainsGateway-223.8214.51-CUSTOM-SNAPSHOT/markerFile

I'll fix it in another PR, and let you know once it's merged, then you can rebase this one, and the CI build will pass.

felladrin added a commit that referenced this pull request Jan 11, 2023
@felladrin
Use separate folders for caching Gradle dependencies from Stable and …
8ce9be7 
…Latest JetBrains Gateway Plugin

It's the same strategy we used on JetBrains Backend Plugin.

Reference: #15646 (comment)
@felladrin felladrin mentioned this pull request Jan 11, 2023
Merged
4 tasks
roboquat pushed a commit that referenced this pull request Jan 11, 2023
@felladrin @roboquat
Use separate folders for caching Gradle dependencies from Stable and …
bcd2b60 
…Latest JetBrains Gateway Plugin

It's the same strategy we used on JetBrains Backend Plugin.

Reference: #15646 (comment)
@felladrin
Copy link
Contributor

felladrin commented Jan 11, 2023 •
edited
Loading

We've merged #15685, which should solve the issue I mentioned above.
Could you then rebase this PR, @zhipengzuo?

@zhipengzuo
Copy link
Contributor Author

We've merged #15685, which should solve the issue I mentioned above. Could you then rebase this PR, @zhipengzuo?

hava push it

@felladrin

This comment was marked as resolved.

Sign in to view
@meysholdt
Copy link
Member

meysholdt commented Jan 12, 2023 •
edited
Loading

I have signed it .

Thank you! I received it.

felladrin
felladrin approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that the issue is not appearing anymore when running when running ./gradlew runIde during development ✅

I've also downloaded the dev-verison of the Plugin, generated by this PR [1], and confirmed it's working ✅

image

Thanks, @zhipengzuo!

@roboquat roboquat merged commit 72a609b into gitpod-io:main Jan 12, 2023
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felladrin felladrin felladrin approved these changes

Assignees
No one assigned
Labels
cla: accepted ✔️ deployed: IDE IDE change is running in production deployed Change is completely running in production editor: jetbrains release-note-none size/XS team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhipengzuo @felladrin @meysholdt @andreafalzetti @roboquat