Skip to content

[Code][Inner Loop] Add Codelens for launching debug workspace window #15735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2023
Merged

[Code][Inner Loop] Add Codelens for launching debug workspace window #15735

merged 1 commit into from
Jan 17, 2023

Conversation

andreafalzetti
Copy link
Contributor

@andreafalzetti andreafalzetti commented Jan 13, 2023 •
edited
Loading

Description

Updates VS Code Stable to the same version 1.74.3 but with cherry picked commits from @jeanp413 and @filiptronicek about gp-run.

with feature flag enabled without
Screenshot 2023-01-13 at 18 43 04 Screenshot 2023-01-13 at 20 38 23

Related Issue(s)

Related #15490

How to test

This feature is behind FG in Configcat ide_service_experimental_rungp.

  1. Using VS Code Browser stable, start a workspace: https://ide-debug-ws-code.preview.gitpod-dev.com/?editor=code-latest#https://github.com/andreafalzetti/gitpod-experiments/tree/imagebuild-broken
  2. Verify that the Code Lens for debug .gitpod.yml and .gitpod.Dockerfile are visibile
  3. Use them, and verify that the Debug Workspace window can be opened and works as expected
  4. Check that IDE is working as expected

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-ide-debug-ws-code.3 because the annotations in the pull request description changed
(with .werft/ from main)

@andreafalzetti andreafalzetti changed the title update vscode [Inner Loop] Update Code to launch gp-run Jan 13, 2023
@andreafalzetti andreafalzetti marked this pull request as ready for review January 13, 2023 20:42
@andreafalzetti andreafalzetti requested a review from a team January 13, 2023 20:42
@akosyakov
Copy link
Member

akosyakov commented Jan 13, 2023 •
edited
Loading

These commits are not enough, you should land 3 commits from https://github.com/gitpod-io/openvscode-server/commits/ak/ide_debug into gp-code/main. They are necessary for debug location to work properly. Actually not sure about user id, i guess it was already addressed on gp-code/main

For How to test you should actually check that you can access the debug window.

@andreafalzetti
Copy link
Contributor Author

andreafalzetti commented Jan 13, 2023 •
edited by werft-gitpod-dev-com bot
Loading

into gp-code/main.

@akosyakov why gp-code/main and not gp-code/release/1.74? 🤔

@akosyakov
Copy link
Member

akosyakov commented Jan 13, 2023 •
edited by werft-gitpod-dev-com bot
Loading

@akosyakov why gp-code/main and not gp-code/release/1.74? 🤔

sorry, in both

  • first put them properly in gp-code/main
  • then cherry pick to last release

it seems though one commit cannot be just cherry picked, but needs changes on gp-code/main

@andreafalzetti andreafalzetti marked this pull request as draft January 13, 2023 23:25
@andreafalzetti andreafalzetti changed the title [Inner Loop] Update Code to launch gp-run [Code][Inner Loop] Add Codelens for launching debug workspace window Jan 14, 2023
@andreafalzetti andreafalzetti marked this pull request as ready for review January 14, 2023 00:55
@andreafalzetti
Copy link
Contributor Author

I've updated this PR with the missing commits

@andreafalzetti
Copy link
Contributor Author

andreafalzetti commented Jan 16, 2023 •
edited
Loading

I am testing this and noticed that codelens is not showing for .gitpod.Dockerfile - I've noticed a new commit yesterday to fix this, I will move this PR to draft and update it again

cc @jeanp413 @filiptronicek

@andreafalzetti andreafalzetti marked this pull request as draft January 16, 2023 13:46
@andreafalzetti andreafalzetti marked this pull request as ready for review January 17, 2023 16:35
@andreafalzetti andreafalzetti mentioned this pull request Jan 17, 2023
Merged
4 tasks
@roboquat roboquat merged commit 63cc17d into main Jan 17, 2023
@roboquat roboquat deleted the ide/debug-ws-code branch January 17, 2023 17:48
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filiptronicek filiptronicek filiptronicek left review comments

@jeanp413 jeanp413 jeanp413 approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/XS team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andreafalzetti @akosyakov @jeanp413 @filiptronicek @roboquat