Skip to content

[server] Extend guardTeamResource with fine-grained ops #16194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Feb 3, 2023

Description

Adds fine-grained operations to teams, pre-cursor to actually start checking for the permissions. For now, these are logged, when the feature flag is enabled.

Related Issue(s)

How to test

Release Notes

NONE

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
  • /werft publish-to-npm

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold for dependency

@easyCZ easyCZ requested a review from a team February 3, 2023 08:40
@easyCZ easyCZ changed the title [server] Cleanup Organization RPCs authorization checks [server] Extend guardTeamResource with fine-grained ops Feb 3, 2023
@roboquat roboquat added the size/M label Feb 3, 2023
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Feb 3, 2023
@easyCZ easyCZ force-pushed the mp/server-team-perms-fine-grained-defs branch from ef16d23 to 7d5bdaa Compare February 3, 2023 08:46
@roboquat roboquat added size/L and removed size/M labels Feb 3, 2023
@easyCZ easyCZ force-pushed the mp/server-teams-simplify branch from 08b7539 to 0dae6ed Compare February 3, 2023 09:50
Base automatically changed from mp/server-teams-simplify to main February 3, 2023 09:59
@easyCZ easyCZ force-pushed the mp/server-team-perms-fine-grained-defs branch from 7d5bdaa to 0d12c9c Compare February 3, 2023 10:00
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome to see this come to fruition. LGTM! ✔️

@easyCZ easyCZ force-pushed the mp/server-team-perms-fine-grained-defs branch from 0d12c9c to 8426ae9 Compare February 3, 2023 10:14
@easyCZ easyCZ force-pushed the mp/server-team-perms-fine-grained-defs branch from 8426ae9 to 9d62a8f Compare February 3, 2023 10:17
@easyCZ
Copy link
Member Author

easyCZ commented Feb 3, 2023

/unhold

@roboquat roboquat merged commit 12f9f6f into main Feb 3, 2023
@roboquat roboquat deleted the mp/server-team-perms-fine-grained-defs branch February 3, 2023 10:27
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants