Skip to content

[supervisor] analyze image file changes #16513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Feb 22, 2023

Description

Adds gitpod_image_file_changed to report when gitpod Dockerfile is changed debounced by 5 secs.

Related Issue(s)

fix #6898

How to test

Verify from sources:

  • Run components/supervisor/validate.sh --log trace to start a workspace.
  • In a new workspace change .gitpod.yml and Dockerfile.
  • Inspect validate logs that changes are detected by file watchers and events are logged in 5 secs after last change is saved.

Release Notes

NONE

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft analytics=segment
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-ak-image-file-changes2.2 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-ak-image-file-changes2.3 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-ak-image-file-changes2.4 because the annotations in the pull request description changed
(with .werft/ from main)

@akosyakov akosyakov force-pushed the ak/image_file_changes2 branch from a288be3 to b228aab Compare February 23, 2023 10:12
@akosyakov akosyakov marked this pull request as ready for review February 23, 2023 10:14
@akosyakov akosyakov requested a review from a team February 23, 2023 10:14
@akosyakov akosyakov force-pushed the ak/image_file_changes2 branch from b228aab to 4d8e5c4 Compare February 23, 2023 10:23
@iQQBot
Copy link
Contributor

iQQBot commented Feb 23, 2023

reviewing

@akosyakov akosyakov force-pushed the ak/image_file_changes2 branch from 4d8e5c4 to deed1d3 Compare February 24, 2023 10:16
@akosyakov akosyakov force-pushed the ak/image_file_changes2 branch from deed1d3 to 9e5bc08 Compare February 24, 2023 10:16
@akosyakov akosyakov requested a review from iQQBot February 24, 2023 10:16
@akosyakov
Copy link
Member Author

akosyakov commented Feb 24, 2023

@iQQBot It should be good for second round 🙏

@akosyakov
Copy link
Member Author

akosyakov commented Feb 24, 2023

/werft run

👍 started the job as gitpod-build-ak-image-file-changes2.9
(with .werft/ from main)

Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit f0d1d1f into main Feb 24, 2023
@roboquat roboquat deleted the ak/image_file_changes2 branch February 24, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement analytics on Dockerfiles
3 participants