Skip to content

Update timeouts layout in user preferences #16653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Mar 3, 2023

Description

Minor follow-up layout updates to the timeouts settings in user preferences:

  1. Simplify section title for readability and future subsections for workspace timeouts in general, see relevant docs.
  2. Remove top margin above the text input
  3. Decrease font weight on the help text

Cc @iQQBot @loujaybee because #16503

BEFORE AFTER
timeouts-before timeouts-after

How to test

Go to /user/preferences and notice the different layout in the timeouts section.

Release Notes

NONE

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@gtsiolis gtsiolis requested a review from a team March 3, 2023 09:44
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 3, 2023
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Mar 3, 2023

Thanks for additionally approving, @iQQBot!

This still requires an approval from @gitpod-io/engineering-webapp.

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Mar 3, 2023

Ready-For-Review 🏓

@iQQBot
Copy link
Contributor

iQQBot commented Mar 3, 2023

I also noticed that our links and text are same color...

image

Billing is link, maybe we can also improve

@gtsiolis gtsiolis force-pushed the gt/update-timeouts-layout branch from ace3b51 to c060693 Compare March 3, 2023 12:35
@roboquat roboquat added size/S and removed size/XS labels Mar 3, 2023
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Mar 3, 2023

Nice catch, @iQQBot! There's already a gp-link class which can be used here safely—added this in c060693.

BEFORE AFTER
link-before link-after

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Mar 6, 2023

Thanks for taking a look, @svenefftinge! 🌮 🌮

@roboquat roboquat merged commit 4d04a75 into main Mar 6, 2023
@roboquat roboquat deleted the gt/update-timeouts-layout branch March 6, 2023 08:56
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants