[Orgs] Persist `slug` #16923

AlexTugarev · 2023-03-20T14:24:52Z

Description

This (re-)introduces persistence of Organization.slug.

New organizations will be given unique slugs. In case of conflicts, the slugified name attribute will be appended by a random string.

Org owners will be able to change the slug under Settings.

Known follow-ups:

backfill slugs for relevant entries
display slug for non-owner of the organization
add slug field to New Organization screen

Related Issue(s)

Part of #16856

How to test

Release Notes

NONE

Documentation

Build Options:

/werft with-werft
Run the build with werft instead of GHA
leeway-no-cache
/werft no-test
Run Leeway with --dont-test

Publish Options

/werft publish-to-npm
/werft publish-to-jb-marketplace

Installer Options

with-ee-license
with-dedicated-emulation
with-ws-manager-mk2
workspace-feature-flags
Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

/werft with-local-preview
If enabled this will build install/preview
/werft with-preview
/werft with-large-vm
/werft with-gce-vm
If enabled this will create the environment on GCE infra
/werft with-integration-tests=all
Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

werft-gitpod-dev-com · 2023-03-20T14:25:00Z

started the job as gitpod-build-at-persist-slug.0 because the annotations in the pull request description changed
(with .werft/ from main)

AlexTugarev · 2023-03-21T12:33:41Z

Just found another issue I'd like to tackle before setting to ready: when changing slug, it needs to get validated. ✔️

AlexTugarev · 2023-03-22T09:28:19Z

/gh run recreate-vm

Comment triggered a workflow run

Started workflow run: 4488322389

recreate_vm: true

gtsiolis

Left a couple of UX comments below. 🏓

Thanks, @AlexTugarev! 🌮 🌮

Approving to unblock merging, holding to address the missing duplicate slug error and for someone to take a closer look at the code changes.

/hold

components/gitpod-db/src/typeorm/team-db-impl.ts

components/dashboard/src/teams/TeamSettings.tsx

gtsiolis · 2023-03-22T11:22:11Z

components/dashboard/src/teams/TeamSettings.tsx

+                    />
+
+                    <TextInputField
+                        label="Slug"


praise: Thanks @AlexTugarev for using the new form components! Thanks also @selfcontained for initially adding[1] the htmlFor element.

components/gitpod-db/src/typeorm/team-db-impl.ts

easyCZ · 2023-03-23T12:11:07Z

components/gitpod-db/src/typeorm/team-db-impl.ts

-            creationTime: new Date().toISOString(),
-        };
-        await teamRepo.save(team);
+        let slug = slugify(name, { lower: true });


I'm guessing we've ensured that the resulting slug from this function does actually conform to the regex which we're enforcing when doing the update.

AlexTugarev · 2023-03-23T17:43:46Z

/gh run recreate-vm

AlexTugarev · 2023-03-24T06:47:28Z

/gh run recreate-vm

Comment triggered a workflow run

Started workflow run: 4508570254

recreate_vm: true

AlexTugarev · 2023-03-24T09:50:15Z

/hold cancel

We'll verify on gitpod-staging.com once more, as the preview env doesn't work anymore.

roboquat added do-not-merge/work-in-progress do-not-merge/release-note-label-needed labels Mar 20, 2023

roboquat added size/M release-note-none and removed do-not-merge/release-note-label-needed labels Mar 20, 2023

AlexTugarev force-pushed the at/persist-slug branch from 9782c0a to 462ac54 Compare March 20, 2023 14:46

roboquat added size/L and removed size/M labels Mar 20, 2023

AlexTugarev force-pushed the at/persist-slug branch 2 times, most recently from 2b53117 to 9949da9 Compare March 20, 2023 15:13

roboquat added size/M size/L and removed size/L size/M labels Mar 20, 2023

selfcontained force-pushed the at/persist-slug branch from b8c6601 to 24a7e6c Compare March 20, 2023 23:37

AlexTugarev force-pushed the at/persist-slug branch 4 times, most recently from 73c138b to 726ce97 Compare March 21, 2023 08:56

AlexTugarev force-pushed the at/persist-slug branch from 726ce97 to 811a8d2 Compare March 21, 2023 12:47

AlexTugarev marked this pull request as ready for review March 21, 2023 13:18

AlexTugarev requested a review from a team March 21, 2023 13:18

AlexTugarev requested a review from gtsiolis as a code owner March 21, 2023 13:18

roboquat removed the do-not-merge/work-in-progress label Mar 21, 2023

github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 21, 2023

gtsiolis approved these changes Mar 22, 2023

View reviewed changes

roboquat added the do-not-merge/hold label Mar 22, 2023

AlexTugarev force-pushed the at/persist-slug branch 2 times, most recently from 92e75c4 to e4b28dd Compare March 22, 2023 16:23

selfcontained force-pushed the at/persist-slug branch from e4b28dd to af2e4d3 Compare March 23, 2023 00:27

easyCZ reviewed Mar 23, 2023

View reviewed changes

components/gitpod-db/src/typeorm/team-db-impl.ts Outdated Show resolved Hide resolved

AlexTugarev force-pushed the at/persist-slug branch from af2e4d3 to 3000b12 Compare March 23, 2023 10:26

roboquat added size/XL and removed size/L labels Mar 23, 2023

AlexTugarev force-pushed the at/persist-slug branch 2 times, most recently from 6549295 to 5a2c5ad Compare March 23, 2023 11:32

easyCZ approved these changes Mar 23, 2023

View reviewed changes

AlexTugarev force-pushed the at/persist-slug branch from 5a2c5ad to cf2a7ef Compare March 23, 2023 17:52

roboquat added size/L and removed size/XL labels Mar 23, 2023

AlexTugarev and others added 4 commits March 24, 2023 09:30

[orgs] Persist slug

1d0a6e8

[Orgs] Make slug changeable on Settings page

fa3ae17

update to use input/button components and mutation

977ef0f

[papi] Re-add Team.slug

4190538

AlexTugarev force-pushed the at/persist-slug branch from cf2a7ef to 4190538 Compare March 24, 2023 09:31

roboquat removed the do-not-merge/hold label Mar 24, 2023

roboquat merged commit 275e782 into main Mar 24, 2023

roboquat deleted the at/persist-slug branch March 24, 2023 09:51

roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Mar 24, 2023

AlexTugarev mentioned this pull request Mar 28, 2023

Introduce slugs for organizations #16856

Closed

[Orgs] Persist slug #16923

[Orgs] Persist slug #16923

Uh oh!

Conversation

AlexTugarev commented Mar 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Known follow-ups:

Related Issue(s)

How to test

Release Notes

Documentation

Build Options:

Preview Environment Options:

Uh oh!

werft-gitpod-dev-com bot commented Mar 20, 2023

Uh oh!

AlexTugarev commented Mar 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlexTugarev commented Mar 22, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment triggered a workflow run

Uh oh!

gtsiolis left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gtsiolis Mar 22, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

easyCZ Mar 23, 2023

Choose a reason for hiding this comment

Uh oh!

AlexTugarev commented Mar 23, 2023

Uh oh!

AlexTugarev commented Mar 24, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment triggered a workflow run

Uh oh!

AlexTugarev commented Mar 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

[Orgs] Persist `slug` #16923

[Orgs] Persist `slug` #16923

AlexTugarev commented Mar 20, 2023 •

edited

Loading

AlexTugarev commented Mar 21, 2023 •

edited

Loading

AlexTugarev commented Mar 22, 2023 •

edited by github-actions bot

Loading

gtsiolis left a comment •

edited

Loading

AlexTugarev commented Mar 24, 2023 •

edited by github-actions bot

Loading