Skip to content

Improve node-labeler #17006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 24, 2023
Merged

Improve node-labeler #17006

merged 4 commits into from
Mar 24, 2023

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Mar 23, 2023

Description

Ensure registry-facade can reach ws-manager by trying to get details from a workspace.

Release Notes

NONE

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=workspace
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

Signed-off-by: Manuel de Brito Fontes <[email protected]>
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-node-labeler-imp.1 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-node-labeler-imp.2 because the annotations in the pull request description changed
(with .werft/ from main)

@aledbf aledbf marked this pull request as ready for review March 23, 2023 20:12
@aledbf aledbf requested a review from a team March 23, 2023 20:12
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Mar 23, 2023
@aledbf
Copy link
Member Author

aledbf commented Mar 23, 2023

/gh run recreate-vm

Comment triggered a workflow run

Started workflow run: 4504818848

  • recreate_vm: true

Signed-off-by: Manuel de Brito Fontes <[email protected]>
Signed-off-by: Manuel de Brito Fontes <[email protected]>
@aledbf aledbf requested a review from WVerlaek March 24, 2023 11:32
Signed-off-by: Manuel de Brito Fontes <[email protected]>
@aledbf aledbf force-pushed the aledbf/node-labeler-imp branch from 4ec9edb to 0e613bb Compare March 24, 2023 11:48
@roboquat roboquat merged commit d2560e2 into main Mar 24, 2023
@roboquat roboquat deleted the aledbf/node-labeler-imp branch March 24, 2023 11:56
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/M team: workspace Issue belongs to the Workspace team
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants