-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Improve node-labeler #17006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Improve node-labeler #17006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel de Brito Fontes <[email protected]>
started the job as gitpod-build-aledbf-node-labeler-imp.1 because the annotations in the pull request description changed |
started the job as gitpod-build-aledbf-node-labeler-imp.2 because the annotations in the pull request description changed |
/gh run recreate-vm Comment triggered a workflow runStarted workflow run: 4504818848
|
WVerlaek
reviewed
Mar 24, 2023
Signed-off-by: Manuel de Brito Fontes <[email protected]>
WVerlaek
reviewed
Mar 24, 2023
Signed-off-by: Manuel de Brito Fontes <[email protected]>
WVerlaek
reviewed
Mar 24, 2023
WVerlaek
approved these changes
Mar 24, 2023
Signed-off-by: Manuel de Brito Fontes <[email protected]>
4ec9edb
to
0e613bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deployed: workspace
Workspace team change is running in production
deployed
Change is completely running in production
release-note-none
size/M
team: workspace
Issue belongs to the Workspace team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure registry-facade can reach ws-manager by trying to get details from a workspace.
Release Notes
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh