Skip to content

[dashboard] add website slugs #18314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2023
Merged

[dashboard] add website slugs #18314

merged 1 commit into from
Jul 19, 2023

Conversation

svenefftinge
Copy link
Member

Description

Changes summary and walkthrough generated by Copilot

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh
  • with-monitoring

/hold

@svenefftinge svenefftinge requested a review from a team July 19, 2023 20:44
@svenefftinge svenefftinge requested a review from gtsiolis as a code owner July 19, 2023 20:44
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 19, 2023
@svenefftinge
Copy link
Member Author

/unhold

@@ -96,6 +96,7 @@ export function isWebsiteSlug(pathName: string) {
"code-of-conduct",
"contact",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"contact",
"contact",
"community",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please create another PR, so we don't spend more time than necessary to roll this out.

@@ -96,6 +96,7 @@ export function isWebsiteSlug(pathName: string) {
"code-of-conduct",
"contact",
"docs",
"events",
"features",
"for",
"gitpod-vs-github-codespaces",
Copy link
Contributor

@ghostdevv ghostdevv Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"gitpod-vs-github-codespaces",
"gitpod-vs-github-codespaces",
"guides",

Copy link
Contributor

@ghostdevv ghostdevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few extra ones that may come in handy 🙏

@roboquat roboquat merged commit be3d71d into main Jul 19, 2023
@roboquat roboquat deleted the se/redirect-events branch July 19, 2023 20:50
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 19, 2023
@ghostdevv ghostdevv mentioned this pull request Aug 7, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants