[server] don't start DB if already running, fix post test db cleanup #18333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenefftinge
force-pushed
the
se/fix-build
branch
from
a4d113f to
ce9d7a5
Compare
|
/unhold |
|
/hold |
svenefftinge
force-pushed
the
se/fix-build
branch
from
ce9d7a5 to
e591a3d
Compare
svenefftinge
commented
Jul 24, 2023
| const manager = await typeorm.getConnection(); | ||
| await manager.getRepository(DBProject).delete({}); | ||
| await manager.getRepository(DBUser).delete({}); | ||
| await resetDB(typeorm); |
There was a problem hiding this comment.
Extracting all post-test DB cleanups to one method (resetDB) that ensures we don't delete needed state (e.g. admin user)
svenefftinge
force-pushed
the
se/fix-build
branch
from
e591a3d to
8be44b5
Compare
svenefftinge
changed the title
svenefftinge
force-pushed
the
se/fix-build
branch
from
8be44b5 to
c19f841
Compare
svenefftinge
force-pushed
the
se/fix-build
branch
from
c19f841 to
8c40335
Compare
svenefftinge
force-pushed
the
se/fix-build
branch
5 times, most recently
from
a9d2861 to
9289c1d
Compare
svenefftinge
force-pushed
the
se/fix-build
branch
from
9289c1d to
af741ed
Compare
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't start the DB (incl. migrations) if it is already running In server's
yarn test🤖 Generated by Copilot at 8be44b5
Refactored and renamed several test files for the
AuthProviderEntryentity and thegitpod-dbmodule. Extracted a commonresetDBfunction to delete all entities except the builtin users before each test. Updated thepackage.jsonfile of thecomponents/servermodule to optimize the test database initialization. Fixed the import paths of theresetDBfunction in some test files of thecomponents/servermodule.Related Issue(s)
Fixes #
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh/hold