Skip to content

Update dev/image tag to latest build #20899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

Conversation

geropl
Copy link
Member

@geropl geropl commented Jun 13, 2025

Summary

• Updates all dev-environment image references to use newly built tag gpl-1425-int-test-gha.33103.
• Ensures consistency across all CI/CD workflows and development environments with updated GitHub CLI v2.74.1

Blocked by: #20898
Fixes CLC-1425

🤖 Generated with Claude Code

@corneliusludmann
Copy link
Contributor

Is the first commit on main already? Do you need to rebase it?

Copy link
Contributor

@corneliusludmann corneliusludmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock.

/hold

Updates all references to use the newly built dev-environment image
that includes the updated GitHub CLI v2.74.1. This ensures consistency
across all CI/CD workflows and development environments.

Related: CLC-1425

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@geropl geropl force-pushed the gpl/1425-update-dev-image-tag branch from dfc0cf1 to a9c162e Compare June 13, 2025 13:25
Copy link
Contributor

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@geropl
Copy link
Member Author

geropl commented Jun 13, 2025

Is the first commit on main already? Do you need to rebase it?

It is, but also, it seems we are using the dev repo now; got confused at first as well: https://github.com/gitpod-io/gitpod/pull/20899/files#diff-06147a8faa12781fca5c634e6177b7923a53e90c95a85d5eca0eb4413eccdc73R1

But this way we get faster. 🪄

@geropl
Copy link
Member Author

geropl commented Jun 13, 2025

I did rebase now.

/unhold

@roboquat roboquat merged commit de92fbc into main Jun 13, 2025
34 checks passed
@roboquat roboquat deleted the gpl/1425-update-dev-image-tag branch June 13, 2025 13:34
@iQQBot
Copy link
Contributor

iQQBot commented Jun 13, 2025

We should always use the image from main build, and this is for security reasons.

@iQQBot iQQBot mentioned this pull request Jun 13, 2025
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants