actually allow to select custom IDE image

[akosyakov]

What it does

• fix [staging] Unable to select custom image #2477: actually allow to select custom IDE image

How to test

• Have custom IDE permission enabled: update d_b_user set rolesOrPermissions = '["admin","devops","ide-settings"]';
• Go to settings
• Try to select "Image" option
• Try to play by typing image and switching radio button. You should not get anything surprising and on reload values should be persisted.

[akosyakov]

@csweichel I think it would be good to add some placehoder for image, do you have something in mind which points to the pattern which shoudl be used.

[csweichel]

@csweichel I think it would be good to add some placehoder for image, do you have something in mind which points to the pattern which shoudl be used.

We could use something that looks like a docker image reference, e.g. index.docker.io/gitpod-io/theia-ide:latest.
For now we don't have a minimal example custom IDE, let alone documentation of how that contract looks like (my Todo, see #2419)

[akosyakov]

We could use something that looks like a docker image reference, e.g. index.docker.io/gitpod-io/theia-ide:latest.
For now we don't have a minimal example custom IDE, let alone documentation of how that contract looks like (my Todo, see #2419)

We could use our theia image in the placeholder? or it is internal secret

btw @JesterOrNot is already looking in to #2419

[csweichel]

We could use something that looks like a docker image reference, e.g. index.docker.io/gitpod-io/theia-ide:latest.
For now we don't have a minimal example custom IDE, let alone documentation of how that contract looks like (my Todo, see #2419)

We could use our theia image in the placeholder? or it is internal secret

It's not a secret per se, but not something we'd want to surface either. Also, it depends on the deployment, i.e. is not a fixed value.

[akosyakov]

@csweichel I added the empty value validation and the placeholder.

[csweichel]

/werft run

👍 started the job as gitpod-build-akosyakov-staging-unable-to-select-2477.11

[csweichel]

LGTM

[yyoncho]

Why Select custom IDE image is disabled for the public gitpod? What are the chances to have that enabled for the public gitpod?

[csweichel]

We've not made this selection public for now, because we fret it would lead to more confusion than do good. The IDE image has very particular requirements that are hard to fulfil, not intuitive and can break things in really strange ways. For example, the IDE image must be built FROM scratch and ideally not touch anything outside of /ide.

Which use-case/IDE do you have in mind?

[yyoncho]

@csweichel

Which use-case/IDE do you have in mind?

I am working on integration between Emacs and gitpod see emacs-lsp/lsp-mode#2845 and
https://github.com/emacs-lsp/lsp-gitpod . It is still a work in progress but it works fine. The issue is that I can specify the image in several ways but there is no way to specify the emacs image globally so I can just open any github project using that image. This issue is one of the blockers.

We've not made this selection public for now, because we fret it would lead to more confusion than do good.

It will work fine for me if this is not public but accessible in a certain way. (e. g. uri param, env variable, etc).

[svenefftinge]

Hey @yyoncho, what you are trying to accomplish sounds pretty cool. I'm not an emacs user myself but if you are interested we could talk through your plans and see how Gitpod can support that and where we would need to change.
https://calendly.com/efftinge/emacs-gitpod

[yyoncho]

@svenefftinge thank you, I scheduled a meeting on Monday.