[server/auth] ensure safe returnTo param#2879
Merged
Merged
Conversation
csweichel
approved these changes
Jan 13, 2021
csweichel
left a comment
Contributor
There was a problem hiding this comment.
works as advertised. LGTM.
Member
Author
|
Thanks for reporting, @payloadartist! 🙏🏻 Just created an update #4567 to be picked up for https://www.gitpod.io/changelog soon. |
FYI you can credit me with my Twitter handle - https://twitter.com/payloadartist in the changelog if you want As I already see someone credited for a security vuln |
|
This was assigned CVE-2021-35206 btw Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR closes an open redirect issue. AFAIK this is problem if an attacker would fake a Gitpod-like website and make people use links with redirects to it. The fake website could potentially ask user to enter sensitive information.
Allowing for Gitpod homepage URLs comes in parallel via #2692. ✔️
how to test