[dashboard] Improve awareness for automatic workspace deletion due to garbage collection #3158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… garbage collection Progresses #2531 but does not resolve.
ghuntley
commented
Feb 17, 2021
Co-authored-by: George Tsiolis <[email protected]>
ghuntley
force-pushed
the
geoff/pin-to-prevent-deletion
branch
from
083c940 to
24c9bae
Compare
TLDR - awesome suggestions. Can you please eyeball it one more time and then hit merge if 👍. |
gtsiolis
approved these changes
Feb 17, 2021
|
Let's merge this! |
|
Oh, just noticed the help link is not using the common pattern used elsewhere in the product (see Learn more). The suggestion in #3158 (comment) was brought up as a future improvement and we need to tackle this across the product. I'll open a follow up PR. UPDATE: See #3203 💡 |
pavan-tri
pushed a commit
to trilogy-group/gitpod
that referenced
this pull request
Apr 28, 2021
… garbage collection (gitpod-io#3158)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progresses #2531 but the language chosen does not resolve the following aspect:
So nit away :)