Skip to content

code: serve ext host worker from own origin #3257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2021
Merged

code: serve ext host worker from own origin #3257

merged 1 commit into from
Feb 23, 2021

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Feb 22, 2021 •
edited
Loading

What it does

Changes in code: gitpod-io/openvscode-server@d632b1f

How to test

  • Enable feature preview and Code.
  • Start a workspace.
  • Check in devtools that ext host worker is running under different origin with extensions- prefix:

Screenshot 2021-02-23 at 09 39 44

@akosyakov akosyakov changed the title server ext host worker from own origin code: server ext host worker from own origin Feb 22, 2021
@akosyakov akosyakov changed the title code: server ext host worker from own origin code: serve ext host worker from own origin Feb 22, 2021
@akosyakov akosyakov force-pushed the akosyakov/code-spawn-ext-host-worker-2856 branch from daa73be to 072639e Compare February 23, 2021 08:23
@akosyakov akosyakov marked this pull request as ready for review February 23, 2021 08:50
@akosyakov
Copy link
Member Author

It works but I noticed that not possible to install any web extension right now. It is because Open VSX does not support latest Microsoft.VisualStudio.Code.WebExtension property and Microsoft.VisualStudio.Code.WebResources asset types.

@akosyakov akosyakov mentioned this pull request Feb 23, 2021
Closed
@akosyakov akosyakov force-pushed the akosyakov/code-spawn-ext-host-worker-2856 branch from 072639e to 81ea267 Compare February 23, 2021 14:00
@akosyakov akosyakov merged commit a20ef08 into master Feb 23, 2021
@akosyakov akosyakov deleted the akosyakov/code-spawn-ext-host-worker-2856 branch February 23, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenefftinge svenefftinge svenefftinge approved these changes

@csweichel csweichel Awaiting requested review from csweichel

@JanKoehnlein JanKoehnlein Awaiting requested review from JanKoehnlein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[code] spawn ext host worker on own origin
2 participants
@akosyakov @svenefftinge