-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add leeway script to update protobuf generated code #3669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aad438e
to
10d44c6
Compare
/werft run 👍 started the job as gitpod-build-aledbf-protobuf.5 |
I don't understand this change. All of the |
7960352
to
4f9afc9
Compare
Fixed. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for cleaning this up.
@@ -22,6 +22,8 @@ import ( | |||
type BlobService struct { | |||
cfg storage.Config | |||
s storage.PresignedAccess | |||
|
|||
api.UnimplementedBlobServiceServer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this change is necessary due to some deliberately non-backwards compatible, idiosyncratic design decisions (grpc/grpc-go#3669 (comment)).
I'm am however not convinced the unimplemented default implementation is preferable to things breaking at compile time. If someone modifies the interface, they should be made aware of the consequences of that action as early as possible.
We can't disable this behaviour though, so we'll have to live with it.
Adds a new leeways script to run the
generate.sh
script:leeway run components:generate-code-from-protobuf
fixes #3630
Issue:
Also, implement change grpc/grpc-go#3669