[server] Increase timeouts for parent prebuilds #4291
Closed
+82
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankeromnes
changed the title
jankeromnes
changed the title
|
Feedback from 1:1 call: Another way to specify the longer timeouts for incremental parent prebuilds could to create a "CommitContextWithTimeout" shape that just adds a |
jankeromnes
force-pushed
the
jx/longer-parent-prebuilds
branch
2 times, most recently
from
e707b73 to
2d6d643
Compare
…l prebuilds are enabled)
jankeromnes
force-pushed
the
jx/longer-parent-prebuilds
branch
from
2d6d643 to
c6d5b0e
Compare
|
🎰 /werft run 👍 started the job as gitpod-build-jx-longer-parent-prebuilds.4 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still unsure what the best approach is here:
Make
WorkspaceStarter.createSpec()fetch the prebuild workspace to check for preconditions (incremental enabled && parent prebuild) before setting the custom timeoutSame but move the preconditions check + custom timeout value into a helper method somewhere else
Add some parameter on the
Workspaceshape that indicates "is a parent prebuild that should run longer"Make
PrebuildManagercallWorkspaceStarter.startWorkspace(ctx, workspace, user, options)with a newoptionsfield (e.g.customTimeout) that gets passed toactuallyStartWorkspaceand then tocreateSpec