Skip to content

[t&p] added permission #4396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

svenefftinge
Copy link
Member

to enable t&p UI under development

to enable t&p UI under development
@svenefftinge
Copy link
Member Author

fixes #4354

@svenefftinge svenefftinge requested a review from jankeromnes June 6, 2021 12:03
@svenefftinge
Copy link
Member Author

svenefftinge commented Jun 6, 2021

/werft run

👍 started the job as gitpod-build-sefftinge-create-feature-flag-for-4354.1

@jankeromnes
Copy link
Contributor

jankeromnes commented Jun 6, 2021

Thanks! What is the benefit of making this a permission instead of a feature flag?

Screenshot 2021-06-06 at 14 46 47

EDIT: Ah, I see that these "Feature Flags" are actually "Workspace Feature Flags" (i.e. they have nothing to do with dashboard UI):

<Property name="Feature Flags"
actions={[{
label: 'Edit Feature Flags',
onClick: () => {
setEditFeatureFlags(true);
}
}]}
>{user.featureFlags?.permanentWSFeatureFlags?.join(', ') || '---'}</Property>

Using a Permission for Teams seems also a bit broken (Teams is actually a feature flag, not a security-related access control) but a Permission is likely the best we have for this currently.

@svenefftinge
Copy link
Member Author

I'll close this as it is a one-liner and you can just do that in your other PR.

@svenefftinge svenefftinge deleted the sefftinge/create-feature-flag-for-4354 branch June 7, 2021 06:53
@jankeromnes
Copy link
Contributor

jankeromnes commented Jun 7, 2021

Thanks!

For what it's worth, I've triggered a io-dev deployment to test this PR: https://werft.gitpod-io-dev.com/job/gitpod-build-se-teams-permission.2

EDIT: Well, that didn't work. Will delete the branches again and test in my PR instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants