Skip to content

[server] add vscode(-insiders) ouath2 clients #5793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[server] add vscode(-insiders) ouath2 clients #5793

wants to merge 6 commits into from

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Sep 21, 2021 •
edited
Loading

Description

It adds 2 new oauth2 clients for Gitpod Server: VS Code Desktop and VS Code Desktop Insiders.

Related Issue(s)

Related to #3733

How to test

Release Notes

NONE

@roboquat roboquat requested a review from csweichel September 21, 2021 14:56
@filiptronicek
Copy link
Member

filiptronicek commented Sep 21, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👎 not authorized

@akosyakov akosyakov mentioned this pull request Oct 6, 2021
Closed
8 tasks
@filiptronicek
Copy link
Member

filiptronicek commented Oct 10, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-server-vscode-ouath2.13

@akosyakov
Copy link
Member Author

akosyakov commented Oct 12, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-server-vscode-ouath2.14

@roboquat roboquat added the team: webapp Issue belongs to the WebApp team label Oct 12, 2021
@filiptronicek filiptronicek mentioned this pull request Oct 13, 2021
Closed
5 tasks
@roboquat roboquat added size/L and removed size/M labels Oct 13, 2021
@akosyakov akosyakov force-pushed the server_vscode_ouath2 branch from 6b48013 to 5aa1548 Compare October 14, 2021 09:48
@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jankeromnes after the PR has been reviewed.
You can assign the PR to them by writing /assign @jankeromnes in a comment when ready.

Associated issue: #3733

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akosyakov akosyakov force-pushed the server_vscode_ouath2 branch from 610cf94 to b963857 Compare October 14, 2021 12:57
@filiptronicek
Copy link
Member

filiptronicek commented Oct 14, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-server-vscode-ouath2.22

@akosyakov
Copy link
Member Author

akosyakov commented Oct 15, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-server-vscode-ouath2.23

@filiptronicek
Copy link
Member

filiptronicek commented Oct 16, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-server-vscode-ouath2.24

@filiptronicek
Copy link
Member

filiptronicek commented Oct 18, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-server-vscode-ouath2.25

@filiptronicek
Copy link
Member

closed in favor of #6272

@filiptronicek filiptronicek deleted the server_vscode_ouath2 branch October 18, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csweichel csweichel Awaiting requested review from csweichel

Assignees
No one assigned
Labels
do-not-merge/work-in-progress release-note-none size/L team: IDE team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akosyakov @filiptronicek @roboquat @loujaybee