Skip to content

Setup IdentitiesOnly as yes in ssh config #7319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

championshuttler
Copy link
Contributor

@championshuttler championshuttler commented Dec 20, 2021

Description

Related Issue(s)

Fixes #7056

How to test

Release Notes

NONE

Documentation

@iQQBot
Copy link
Contributor

iQQBot commented Dec 21, 2021

Hi @championshuttler Thanks for your contribution, and could you please use our PR template? 🙏

@iQQBot
Copy link
Contributor

iQQBot commented Dec 21, 2021

/werft run

👍 started the job as gitpod-build-identit-fork.0

Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2f3b4c046ed7667df4427d55176d0b2154054767

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #7319 (b4c8604) into main (de31383) will increase coverage by 11.60%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            main    #7319       +/-   ##
==========================================
+ Coverage   7.44%   19.04%   +11.60%     
==========================================
  Files         15        2       -13     
  Lines       1330      168     -1162     
==========================================
- Hits          99       32       -67     
+ Misses      1228      134     -1094     
+ Partials       3        2        -1     
Flag Coverage Δ
components-local-app-app-linux-amd64 19.04% <ø> (ø)
components-local-app-app-linux-arm64 ∅ <ø> (∅)
components-local-app-app-windows-386 ∅ <ø> (∅)
components-local-app-app-windows-amd64 ∅ <ø> (∅)
components-local-app-app-windows-arm64 ∅ <ø> (∅)
installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...staller/pkg/components/ws-manager/networkpolicy.go
installer/pkg/components/ws-manager/configmap.go
...components/ws-manager/unpriviledged-rolebinding.go
installer/pkg/common/render.go
installer/pkg/components/ws-manager/rolebinding.go
installer/pkg/components/ws-manager/role.go
installer/pkg/components/ws-manager/tlssecret.go
installer/pkg/common/display.go
installer/pkg/common/common.go
installer/pkg/common/storage.go
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de31383...b4c8604. Read the comment docs.

@akosyakov
Copy link
Member

/hold

@meysholdt do we require CLA?

@akosyakov akosyakov added the do-not-merge/cla-pending CLA has not been signed label Dec 21, 2021
@akosyakov
Copy link
Member

@championshuttler please use original PR template, it has important directives for our bot

@iQQBot
Copy link
Contributor

iQQBot commented Dec 21, 2021

Yes, he is signed CLA @akosyakov

@akosyakov
Copy link
Member

/unhold

ok, then only updating the PR description is left

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iQQBot

Associated issue: #7056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit d8e1eaa into gitpod-io:main Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not establish connection to workspace-unique-name
4 participants