Skip to content

[local-app] fix timeout chan no consumer #7420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2022
Merged

[local-app] fix timeout chan no consumer #7420

merged 1 commit into from
Jan 3, 2022

Conversation

mustard-mh
Copy link
Contributor

Description

check before push data into chan

Related Issue(s)

Fixes #7419

How to test

Release Notes

NONE

Documentation

@mustard-mh
Copy link
Contributor Author

/assign @akosyakov

@mustard-mh
Copy link
Contributor Author

/assign @iQQBot

@iQQBot
Copy link
Contributor

iQQBot commented Jan 3, 2022

/werft run

👍 started the job as gitpod-build-mh-fix-local-app-fork.0

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #7420 (1c549a8) into main (34ed8e2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7420   +/-   ##
=======================================
  Coverage   19.04%   19.04%           
=======================================
  Files           2        2           
  Lines         168      168           
=======================================
  Hits           32       32           
  Misses        134      134           
  Partials        2        2           
Flag Coverage Δ
components-local-app-app-linux-amd64 19.04% <ø> (ø)
components-local-app-app-linux-arm64 ∅ <ø> (∅)
components-local-app-app-windows-386 ∅ <ø> (∅)
components-local-app-app-windows-amd64 ∅ <ø> (∅)
components-local-app-app-windows-arm64 ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34ed8e2...1c549a8. Read the comment docs.

Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @mustard-mh

@roboquat roboquat added the lgtm label Jan 3, 2022
@roboquat
Copy link
Contributor

roboquat commented Jan 3, 2022

LGTM label has been added.

Git tree hash: 5e3865e2825c83e245649a42e4353f17bbe3a50d

@roboquat
Copy link
Contributor

roboquat commented Jan 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iQQBot

Associated issue: #7419

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akosyakov akosyakov mentioned this pull request Jan 3, 2022
2 tasks
@roboquat roboquat merged commit f1c0b8f into gitpod-io:main Jan 3, 2022
@akosyakov
Copy link
Member

akosyakov commented Jan 3, 2022

@mustard-mh thanks for following up 🙏 We should work on quality for VS Code Desktop and local companion. Right now they are our weak points and bugs can slip 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VS Code Desktop cannot connect on staging
4 participants