-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Support more regional workspace cluster #7490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Associated issue: #6164 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f3a7d1a
to
b04b72b
Compare
1e045d7
to
30169f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting to see progress on this! ⚡ 👏 Many thanks for moving this forward. 🙏
Added a few drive-by comments in the dashboard part. Please disregard if unhelpful.
My thoughts on this
|
f60553a
to
5b1de04
Compare
[server] Test RTT for available workspace cluster only [dashboard] Improve RTT measurement [dashboard] enable RTT measurement
59b849f
to
98ee125
Compare
Codecov Report
@@ Coverage Diff @@
## main #7490 +/- ##
=========================================
+ Coverage 8.68% 10.38% +1.69%
=========================================
Files 33 18 -15
Lines 2325 992 -1333
=========================================
- Hits 202 103 -99
+ Misses 2119 888 -1231
+ Partials 4 1 -3
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Code LGTM now, also squashed it. I admit that I am stuck in the testing steps as I don't know how to register a different preview env's ws-manager: What is the URL? The one of the local preview env is a |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Closing per conversation with @csweichel |
Description
Today workspace cluster choice is guided solely by the location of the application cluster the workspace is started from. This PR introduces an admission preference (introduced in #6164) which adds more regional support.
The current implementation in this branch is a rather rough first start. It does two things:
region
admission preferences on workspace clusters. Each such admission preference carries a "round trip time endpoint" which is used to measure the RTT of a user to a particular region. We assume that if there are multiple clusters within the same "region" that their "RTT endpoints" yield equivalent results.start workspace
page measure the RTT and update the cluster preference for the user. This part I'm least happy with, because it'sIt's particularly with point 2 that I'd need some support @gitpod-io/engineering-meta :)
Related Issue(s)
Fixes #5596
How to test
WSMAN_CFG
env var on server setting it toW10K
(base64 for[]
)gpctl clusters register ...
make sure it's governedgpctl clusters update admission-preference add ...
to point one cluster to a "slow" RTT endpoint, e.g.ws-us25.gitpod.io
, and one to a "fast" RTT endpoint, e.g.ws-eu25.gitpod.io
(depending on where in the world you're located)Release Notes
Documentation