Skip to content

[jetbrains] experimental support of warm up in prebuilds #9450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2022
Merged

[jetbrains] experimental support of warm up in prebuilds #9450

merged 1 commit into from
Apr 25, 2022

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Apr 21, 2022 •
edited
Loading

Description

It introduces very experimental support of warming up JetBrains's products in prebuilds. It is based on a synthetic task inferred from .gitpod.yml configuration. Here is an example:

jetbrains:
  intellij:
    plugins:
      - com.haulmont.jpab
    prebuilds:
      version: stable
  goland:
    prebuilds:
      version: latest
  pycharm:
    prebuilds:
      version: both

A user can configure which products should be warmed up during prebuild and controls whether stable, latest or both version should be indexed.

Caveat: This approach does not respect plugins and versions of JB products how they are treated by JB imaged produced by Gitpod. Ideally we should layer such images and move logic there.

Related Issue(s)

Related to #6740

How to test

Proper way

Lazy way

Release Notes

Added experimental support of warming up JetBrains's products in prebuilds via .gitpod.yml.

Documentation

  • /werft with-vm

@akosyakov akosyakov force-pushed the akosyakov/improve-importing-indexing-6740 branch from f5b8dd3 to 02196f7 Compare April 21, 2022 09:30
@roboquat roboquat added size/XL and removed size/L labels Apr 21, 2022
@akosyakov akosyakov force-pushed the akosyakov/improve-importing-indexing-6740 branch 3 times, most recently from 7091687 to c1d7453 Compare April 21, 2022 12:11
@roboquat roboquat added size/L and removed size/XL labels Apr 21, 2022
Base automatically changed from akosyakov/improve-importing-indexing-6740 to main April 21, 2022 13:39
@roboquat roboquat added size/XL and removed size/L labels Apr 21, 2022
@akosyakov
Copy link
Member Author

akosyakov commented Apr 21, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-ak-jb-prebuilds.4

@akosyakov
Copy link
Member Author

akosyakov commented Apr 21, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-ak-jb-prebuilds.5

@roboquat roboquat added size/L and removed size/XL labels Apr 21, 2022
@iQQBot
Copy link
Contributor

iQQBot commented Apr 21, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-vm

👍 started the job as gitpod-build-ak-jb-prebuilds.7

@akosyakov akosyakov force-pushed the ak/jb_prebuilds branch 3 times, most recently from dadc91b to eeef77f Compare April 22, 2022 11:00
@akosyakov akosyakov marked this pull request as ready for review April 22, 2022 12:59
@akosyakov akosyakov requested a review from a team April 22, 2022 12:59
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 22, 2022
@akosyakov akosyakov requested a review from felladrin April 22, 2022 14:18
felladrin
felladrin approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed and tested according to the instructions! All good! ✅

Screenshot 2022-04-22 at 11 55 50

Screenshot 2022-04-22 at 12 06 14

Screenshot 2022-04-22 at 12 13 16

geropl
geropl reviewed Apr 25, 2022
View reviewed changes
components/server/src/workspace/workspace-starter.ts
@@ -119,6 +120,7 @@ export interface StartWorkspaceOptions {
const MAX_INSTANCE_START_RETRIES = 2;
const INSTANCE_START_RETRY_INTERVAL_SECONDS = 2;

// TODO(ak) move to IDE service
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

geropl
geropl reviewed Apr 25, 2022
View reviewed changes
components/server/src/ide-service.ts
* See License-AGPL.txt in the project root for license information.
*/

import { JetBrainsConfig, TaskConfig, Workspace } from "@gitpod/gitpod-protocol";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: ideally we had a top-level package ide to move the other stuff into. But that's a clear follow-up.

geropl
geropl approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code, LGTM!

@geropl geropl self-assigned this Apr 25, 2022
@roboquat roboquat merged commit 614c0c7 into main Apr 25, 2022
@roboquat roboquat deleted the ak/jb_prebuilds branch April 25, 2022 07:51
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

@felladrin felladrin felladrin approved these changes

Assignees

@geropl geropl

Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akosyakov @iQQBot @felladrin @geropl @roboquat