Skip to content

feat(gitpod): adjust community links #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ghuntley
Copy link

@ghuntley ghuntley commented Jul 28, 2021

nb. I have not tested these changes. They were done via eyeballing the code.

@ghuntley ghuntley marked this pull request as ready for review July 28, 2021 01:08
@ghuntley ghuntley requested a review from akosyakov July 28, 2021 01:08
@akosyakov
Copy link
Member

It would be good to create a PR in gitpod-io/gitpod which switches to this commit to verify: https://github.com/gitpod-io/gitpod/blob/c9f4c4b22c4840f400ced40c01f94e87c8ffb957/components/ide/code/leeway.Dockerfile#L45

@ghuntley
Copy link
Author

ghuntley commented Aug 4, 2021

Test results

Passed

  • CMD+SHIFT+P -> Twitter -> Twitter Opens
  • CMD+SHIFT+P -> Chat -> Discord Opens
  • CMD+SHIFT+P -> Forum -> Discourse Opens

2021-08-04_17-50-14

Failed

2021-08-04_17-52-41

2021-08-04_17-52-54

@akosyakov akosyakov force-pushed the gp-code branch 19 times, most recently from 1e5c70d to 126b2f5 Compare August 10, 2021 12:52
@akosyakov akosyakov changed the base branch from gp-code to gp-code-1.58.2 August 11, 2021 08:55
@akosyakov
Copy link
Member

I will port it to gp-code, since it is hard to rebase after recent refactoring.

@akosyakov
Copy link
Member

ported and fixed

@akosyakov akosyakov closed this Aug 11, 2021
@akosyakov akosyakov deleted the gh/community-links branch August 11, 2021 09:06
mustard-mh pushed a commit that referenced this pull request Apr 13, 2025
Co-authored-by: meganrogge <[email protected]>
mustard-mh pushed a commit that referenced this pull request Apr 13, 2025
Co-authored-by: meganrogge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants