Make use of Name on the port label, and Description on port tooltip #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felladrin
changed the title
jeanp413
force-pushed
the
gp-code/main
branch
from
4fe2a9f to
c53ef1f
Compare
akosyakov
force-pushed
the
gp-code/main
branch
from
c53ef1f to
5107052
Compare
|
@felladrin it looks good, could you squash please in one commit, we try to keep history small and logical, several commits are fine when they are several logical parts are changed |
It is fine to merge like that. It is important that changes work in backward compatible manner. |
akosyakov
force-pushed
the
gp-code/main
branch
from
5107052 to
fbd9385
Compare
|
@felladrin Could you rebase again? Sorry, there is nightly job which sync with upstream MS repo each night, so we have to rebase PRs. Maybe we could automate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves gitpod-io/gitpod#3059.
It's related to gitpod-io/gitpod#7012 changes.
It has backward compatibility to run on VS Code in a cluster where the supervisor is not exposing Port Name/Description yet.
Here's an example of hovering a port which has
port.name === "extension"andport.description === "Extension Host Process":