-
Notifications
You must be signed in to change notification settings - Fork 474
Basic auth flow #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic auth flow #26
Conversation
…in-header-dev-dependency Makes eslint-plugin-header a dev dependency
343f447
to
61bc66c
Compare
One more thing basic oauth should not be contributed to server.main.ts, only via server.ts. We are not going to use it in Gitpod and should not have unnecesray deps then. |
61bc66c
to
3c22b7d
Compare
@akosyakov Auth is now separate from the main implementation. Care to take another look? Also removed all additional dependencies. |
bc5c75e
to
69807bc
Compare
Can we revert to minimal change? I cannot really understand what was changed in server.main.ts. The PR should be:
There is no need for unnecessary refactoring and so on. |
f0ea2d6
to
9c9fcf1
Compare
Web sockets are not secured. |
Co-authored-by: bigint <[email protected]>
Co-authored-by: bigint <[email protected]>
Co-authored-by: bigint <[email protected]>
Co-authored-by: bigint <[email protected]>
Co-authored-by: bigint <[email protected]>
7035e0c
to
ac5a28c
Compare
@msujew Could you rebase please? Some minor comments:
|
ac5a28c
to
cc6782d
Compare
Well, the alternative would be the redirect. I don't think there's a way around that, as that's something implemented by the browser, not by us. |
cc6782d
to
b3890fe
Compare
83304ac
to
cd9ff4e
Compare
We discussed it and decided to put it on hold, try without built-in auth for now. Please don't feel discouraged, contribution is good! |
e5ef0eb
to
69a3821
Compare
acafaa0
to
539e157
Compare
I was able to accomplish this with a Caddy reverse proxy in front and basic auth there. |
I'm closing it. The goal of the project just to provide easy to maintain open source server. Integration issues should be resolved by adopters or end users. That said, it does not mean that there could not be guides showing how to securely setup the server. Anyone is welcomed to contribute them. |
Implements a basic auth flow. Shows a login page when the server has been started with
--password=<password>
. Inserting the correct password redirects to the application, while a wrong password brings the user back to the login.