Skip to content
This repository was archived by the owner on Apr 25, 2026. It is now read-only.

make site valid in accordance to W3C validator. - #932

Open
nisarhassan12 wants to merge 1 commit into
masterfrom
nisarhassan12/seo-improvements-842
Open

make site valid in accordance to W3C validator.#932
nisarhassan12 wants to merge 1 commit into
masterfrom
nisarhassan12/seo-improvements-842

Conversation

@nisarhassan12

@nisarhassan12 nisarhassan12 commented Jan 5, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #868
Addresses the following from gitpod-io/website#842

image

@nisarhassan12
nisarhassan12 marked this pull request as draft January 5, 2021 14:02
@nisarhassan12 nisarhassan12 mentioned this pull request Jan 5, 2021
Open
30 of 35 tasks
@nisarhassan12
nisarhassan12 force-pushed the nisarhassan12/seo-improvements-842 branch 3 times, most recently from 786452f to 608f0a6 Compare January 5, 2021 16:27
@nisarhassan12

nisarhassan12 commented Jan 5, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Not sure How we can get rid of these errors will look it up later:

image

image

Todo

I will inspect later how these can be addressed.

/pricing

image

image

I'm done testing most of the pages apart from /docs, individual blog post and Imprint, ToS, Privacy Policy.

@nisarhassan12
nisarhassan12 force-pushed the nisarhassan12/seo-improvements-842 branch 2 times, most recently from 5df1a08 to 9d3a5ab Compare January 5, 2021 17:47
@nisarhassan12

nisarhassan12 commented Jan 5, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

According to W3C we should avoid nesting Links:

image

But currently, we're doing it on https://www.gitpod.io/blog in the PostPreview Card

image

Removing the links from the author name would fix this issue. @ChristinFrohne Is this ok to remove the links from the names? Thanks

image

EDIT

The issue is quite critical that it caused the other errors to be ignored.

@nisarhassan12
nisarhassan12 force-pushed the nisarhassan12/seo-improvements-842 branch from 9d3a5ab to d2519a9 Compare January 5, 2021 18:46
@chrifro

chrifro commented Jan 7, 2021

Copy link
Copy Markdown
Contributor

@nisarhassan12 I just noticed that the links to the author's profile are not working anyways. So you can just remove the link completely from the overview page. On each blog post the link to the author's profile needs to be there though.

@nisarhassan12
nisarhassan12 force-pushed the nisarhassan12/seo-improvements-842 branch from d2519a9 to b96ebcf Compare January 7, 2021 09:10
@nisarhassan12
nisarhassan12 force-pushed the nisarhassan12/seo-improvements-842 branch 3 times, most recently from 835f452 to 9f47a41 Compare January 18, 2021 15:57
@nisarhassan12
nisarhassan12 force-pushed the nisarhassan12/seo-improvements-842 branch from 9f47a41 to 3ee3d1d Compare January 18, 2021 16:00
@nisarhassan12
nisarhassan12 marked this pull request as ready for review January 18, 2021 16:01
@nisarhassan12
nisarhassan12 requested a review from chrifro January 18, 2021 16:01

This branch has not been deployed

No deployments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chrifro chrifro Awaiting requested review from chrifro

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

validate the entire site with w3c validator and fix the issues for better SEO results.

2 participants

@nisarhassan12 @chrifro