BUGFIX: 627 fix include order #628
Conversation
* Add include files to the beginning to parse them right after the file containing the include directive. * This way more specific config files will overrule the configurations. Resolves: #627
|
There might be a pythonic way of solving this, but as I'm a beginner im happy to provide at least a fix for the issue. |
There was a problem hiding this comment.
First of all, sorry for letting this PR wait for so long, despite me being super happy about every contribution!
So thanks a lot for taking the time to make it!
Besides that simple improvement in readability, do you think you can figure out how to adjust this test-case to assert for the change this PR is making?
You should be able run the config tests via nosetests git/test/test_config.py from the root of this repository.
If adjusting the test doesn't work for you, after all it's not particularly easy to understand and quite complex/convoluted, please let me know and we find another way.
Thanks and cheers
| num_read_include_files += 1 | ||
| include_paths.reverse() |
There was a problem hiding this comment.
I think this block should be rewritten like this:
files_to_read = include_paths + files_to_readThis makes clearer that included files should be read and merged first.
Resolves: #627