Skip to content

Allow mmap not just for py2.6, 2.7 and 3.6+ but also 3.0+ #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2018
Merged

Allow mmap not just for py2.6, 2.7 and 3.6+ but also 3.0+ #736

merged 1 commit into from
Mar 18, 2018

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Mar 18, 2018

This version check only checks the minor number: the y in Python x.y.

So mmap is available for Python 2.6 and 2.7, and 3.6+, but not for 3.0 to 3.5.

But I think the intent was to have memory maps for Python 2.6 and up, including all of Python 3.x (and 4.x etc.).

As Python 2.6 is the minimum supported version, the allow_mmap is always True for supported versions.

@Byron Byron merged commit 9f12b26 into gitpython-developers:master Mar 18, 2018
@codecov-io
Copy link

Codecov Report

Merging #736 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #736      +/-   ##
==========================================
- Coverage   94.66%   94.66%   -0.01%     
==========================================
  Files          60       60              
  Lines        9340     9338       -2     
==========================================
- Hits         8842     8840       -2     
  Misses        498      498
Impacted Files Coverage Δ
git/index/base.py 94.64% <100%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 190c045...693b171. Read the comment docs.

@Byron
Copy link
Member

Byron commented Mar 18, 2018

What a great catch! Thanks a lot for your contribution!

@hugovk hugovk deleted the fix-version-check branch March 18, 2018 20:42
@Byron Byron added this to the v2.1.9 - Bugfixes milestone Mar 24, 2018
riley-martine pushed a commit to riley-martine/GitPython that referenced this pull request Dec 7, 2023
…heck

Allow mmap not just for py2.6, 2.7 and 3.6+ but also 3.0+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants