Skip to content

Avoid from_timestamp() function to raise an exception when the offset… #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2018
Merged

Avoid from_timestamp() function to raise an exception when the offset… #746

merged 1 commit into from
Apr 4, 2018

Conversation

ishepard
Copy link
Contributor

@ishepard ishepard commented Apr 4, 2018 •
edited
Loading

… is greater or lower than 24 hours.

Add tests that exercise the new behaviour

Fix #741

@ishepard
Avoid from_timestamp() function to raise an exception when the offset…
de54a81 
… is greater or lower than 24 hours.

Add tests that exercise the new behaviour
@ishepard ishepard changed the title Fix #741 Avoid from_timestamp() function to raise an exception when the offset… Avoid from_timestamp() function to raise an exception when the offset… Apr 4, 2018
@Byron Byron added this to the v2.1.10 - Bugfixes milestone Apr 4, 2018
@Byron
Copy link
Member

Byron commented Apr 4, 2018

Thanks so much for your help! It’s already worth a new patch release!

@Byron Byron merged commit c6e0a6c into gitpython-developers:master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
v2.1.10 - Bugfixes
Development

Successfully merging this pull request may close these issues.
2 participants
@ishepard @Byron