Skip to content

remove crate custom color type and use tui-rs #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
extrawurst opened this issue Jun 23, 2020 · 2 comments · Fixed by #391
Closed

remove crate custom color type and use tui-rs #149

extrawurst opened this issue Jun 23, 2020 · 2 comments · Fixed by #391
Labels
enhancement New feature or request

Comments

@extrawurst
Copy link
Collaborator

since fdehau/tui-rs#292 is done we can get rid of ui::style::ColorDef
@extrawurst extrawurst added enhancement New feature or request good first issue Good for newcomers labels Jun 23, 2020
@extrawurst extrawurst changed the title remove crate custom color type and use tub-rs remove crate custom color type and use tui-rs Jun 23, 2020
@MCord
Copy link
Contributor

MCord commented Jun 23, 2020

The serialization feature is not yet released. the current version 0.9.5 does not contain the mentioned change.

@extrawurst
Copy link
Collaborator Author

@MCord you are right, I missed that fact :(

@extrawurst extrawurst mentioned this issue Jul 18, 2020
Closed
@extrawurst extrawurst removed the good first issue Good for newcomers label Sep 16, 2020
1wilkens added a commit to 1wilkens/gitui that referenced this issue Oct 30, 2020
@1wilkens
Remove ui::style::ColorDef in favor tui-rs type
76bae0e 
Closes gitui-org#149.
@1wilkens 1wilkens mentioned this issue Oct 30, 2020
Merged
extrawurst pushed a commit that referenced this issue Oct 31, 2020
@1wilkens
Remove ui::style::ColorDef in favor up tui::style::Color (#391)
21b7513 
Closes #149.
extrawurst pushed a commit that referenced this issue May 27, 2021
@1wilkens
Remove ui::style::ColorDef in favor up tui::style::Color (#391)
e3bd1c1 
Closes #149.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ui::style::ColorDef in favor up tui::style::Color 1wilkens/gitui
2 participants
@extrawurst @MCord