Skip to content

Add signoffto commits #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
domtac opened this issue Jul 12, 2023 · 2 comments · Fixed by #1758
Closed

Add signoffto commits #1757

domtac opened this issue Jul 12, 2023 · 2 comments · Fixed by #1758
Labels

Comments

@domtac
Copy link
Contributor

domtac commented Jul 12, 2023

Projects I am working on are requiring to have signed-off commits to trace the origin of changes.
Here is the documentation to this git feature

I would propose, having this as an option to apply this to all following commits or use capital c when committing to sign the commit off

@extrawurst
Copy link
Collaborator

extrawurst commented Jul 13, 2023

https://docs.pi-hole.net/guides/github/how-to-signoff/

Sounds like what's required is a command that should just add text to the commit message, or am I missing something?

@extrawurst extrawurst added the good first issue Good for newcomers label Jul 13, 2023
@domtac
Copy link
Contributor Author

domtac commented Jul 13, 2023

Yeah more or less,
actually author name and mail will be added to the commit. I am working on a couple of projects where it is required to sign-off.
So if you write a commit message done stuff with the sign-off option this commit message will be generated:

done stuff

Signed-off-by My Name <[email protected]> 

I am working on a first draft on that and hope to provide a pull request today for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants