Skip to content

Different behavior on create and rename branch dialogs #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RexTremendae opened this issue May 4, 2021 · 2 comments · Fixed by #700
Closed

Different behavior on create and rename branch dialogs #679

RexTremendae opened this issue May 4, 2021 · 2 comments · Fixed by #700
Labels
good first issue Good for newcomers
Milestone
v0.16

Comments

@RexTremendae
Copy link
Contributor

Describe the bug
In the branch dialog, the create and rename pop-ups have inconsistent behavior. The rename is a pop-up on top of the branch dialog, but the create pop-up closes it.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the branches dialog from either Status[1] or Log[2]
  2. Select Create Branch
  3. Press Esc to cancel the dialog

Expected behavior
I should come back to the branch dialog (just like the rename pop-up works) but the branch dialog is closed and I go back to the main view instead.

Screenshots
create_vs_rename

Context (please complete the following information):

  • Windows 10 (19042.928)
  • GitUI v0.15.0
  • Rust version: ??
@extrawurst
Copy link
Collaborator

Sounds like a reasonable improvement

@extrawurst extrawurst added the good first issue Good for newcomers label May 4, 2021
bc-universe added a commit to bc-universe/gitui that referenced this issue May 10, 2021
@bc-universe
Preserves same modal behavior per gitui-org#679
dcf1942
@bc-universe bc-universe mentioned this issue May 10, 2021
Merged
extrawurst pushed a commit that referenced this issue May 11, 2021
@bc-universe
Preserves same modal behavior per #679
a3b4b98
@extrawurst extrawurst linked a pull request May 11, 2021 that will close this issue
Preserves same branch dialog behavior #700
Merged
@extrawurst
Copy link
Collaborator

closed via #700

@extrawurst extrawurst added this to the v0.16 milestone May 11, 2021
extrawurst pushed a commit that referenced this issue May 27, 2021
@bc-universe
Preserves same modal behavior per #679
cbf5f90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
v0.16
Development

Successfully merging a pull request may close this issue.

Preserves same branch dialog behavior bc-universe/gitui
2 participants
@extrawurst @RexTremendae