Change focus when current list is empty #1165
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extrawurst
reviewed
Mar 8, 2022
| @@ -412,6 +412,7 @@ impl Status { | |||
| .unwrap_or(RepoState::Clean); | |||
|
|
|||
| self.branch_compare(); | |||
| self.update_status()?; | |||
There was a problem hiding this comment.
I have to look deeper into this, why Is this needed?
There was a problem hiding this comment.
- staging signal: https://github.com/extrawurst/gitui/blob/c2d57fca987248c1b6f60750d6cef55c79aab8d6/src/components/changes.rs#L269
- signal handler: https://github.com/extrawurst/gitui/blob/c2d57fca987248c1b6f60750d6cef55c79aab8d6/src/app.rs#L654
- status tab handler: https://github.com/extrawurst/gitui/blob/c2d57fca987248c1b6f60750d6cef55c79aab8d6/src/tabs/status.rs#L395
I need to change focus here if nessary.
|
bug report for this: #1169 |
|
this solution behaves odly when one switches focus back to the empty work space:
|
|
superseded by #1170 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #{issue_num}.
this is a feature enhancement.
It changes the following:
Most of the time, when I staging all the files, the next step is to commit, in current version I need to press the arrow down key or 'w' to change focus manually. But I think gitui can change focus for me :) , that is when current list is empty just try to change focus. I don't know this is a feature other people need too. If not, just close this pr.
I followed the checklist:
make checkwithout errors