Skip to content

Improve UI selection and command bar #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 30, 2022

Conversation

Gigitsu
Copy link
Contributor

@Gigitsu Gigitsu commented Aug 29, 2022

It changes the following:

  • Selected line in log and files tab now fill the entire container
  • Command bar visible commands uses a different background colour than the selection_bg colour

Before the patch

files tab before

log tab before

After the patch

files tab after

log tab after

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@Gigitsu Gigitsu changed the title Feature/improve UI selection Improve UI selection and command bar Aug 29, 2022
@Gigitsu
Copy link
Contributor Author

Gigitsu commented Aug 29, 2022

The nightly build on windows won't compile.

I can see this error started from this commit on master but I cannot find the reason. I tried to compare my last commit to last working commit without finding a reason for the error.

@extrawurst extrawurst merged commit bacf81f into gitui-org:master Aug 30, 2022
@extrawurst
Copy link
Collaborator

looks good to me, will make the command bar color default back to blue on master after merge

@Gigitsu Gigitsu deleted the feature/improve-ui-selection branch August 30, 2022 12:06
IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this pull request Jun 4, 2024
* Added new color for commands bar
* Made commit list item and file tree item fill the entire row
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants