-
-
Notifications
You must be signed in to change notification settings - Fork 608
Add no-verify commit command #1375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
yeah I think I would prefer an option that we can toggle with the new key and that resets back to the |
I have been using this and it does work fine with the amend workflow. I can look into adding it as an option, this makes for less "action" items on the menu bar, but does add a keystroke in the workflow. You have to set the option and then hit commit. As it is now, you can just hit That said adding options to this menu could well be extended into other flags as well, so that could be a good thing. I'd have to dig through the code a bit more to see how you are handing options, but happy to do so. Thanks for taking a look here. Cheers! |
e01bff2
to
06f55c0
Compare
Howdy @extrawurst , I've updated this to be a flag on the Let me know if this is what you had in mind, re: "toggle with new key". I'll be taking it for a spin for the rest of the week. Cheers, |
c4515b1
to
3938f27
Compare
lgtm! Thanks you. will create the relevant changelog |
* add no-verify option on commit action * make verify a bool flag on commit component
Thanks @extrawurst , I am really enjoying daily driving gitui! |
* add no-verify option on commit action * make verify a bool flag on commit component
This Pull Request fixes/closes #1374.
It changes the following:
I think there is likely a cleaner way that just adds a "no-verify" or "no-hooks" option, but maybe this works fine. It seems the the
amend
workflow could probably still use this.I followed the checklist:
make check
without errors